inject for free programs #1526
Merged
inject for free programs #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this is a handy method. But it looks like you have a compile error :) The implementation is fairly trivial, but I think at least an sbt-doctest example (if not also a separate test) would be great. |
|
Doh, I was compiling core instead of free. |
Current coverage is 92.26% (diff: 100%)@@ master #1526 diff @@
==========================================
Files 246 246
Lines 3763 3764 +1
Methods 3637 3639 +2
Messages 0 0
Branches 126 125 -1
==========================================
+ Hits 3472 3473 +1
Misses 291 291
Partials 0 0
|
|
👍 LGTM |
|
👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
injectoperation forFreethat lifts programs rather than constructors. This allows you to use existingFreeprograms (like doobieConnectionIO) in coproducts without having to write implicit modules of lifted constructors.I'll add a test if people think this is useful.